Simplify null string handling

Signed-off-by: Marcel Coetzee <[email protected]>
dlt-hub · Aug 29, 2024 · 8afa7e1 · 8afa7e1
1 parent c07c8fc
commit 8afa7e1
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/dlt/destinations/impl/lancedb/lancedb_client.py b/dlt/destinations/impl/lancedb/lancedb_client.py
@@ -725,11 +725,13 @@ def run(self) -> None:
         if (self._job_client.config.embedding_model_provider == "openai") and (
             source_columns := get_columns_names_with_prop(self._load_table, VECTORIZE_HINT)
         ):
-            records: List[Dict[str, Any]]
-            for record in records:
-                for k, v in record.items():
-                    if k in source_columns and not v:
-                        record[k] = EMPTY_STRING_PLACEHOLDER
+            records = [
+                {
+                    k: EMPTY_STRING_PLACEHOLDER if k in source_columns and v in ("", None) else v
+                    for k, v in record.items()
+                }
+                for record in records
+            ]
 
         if self._load_table not in self._schema.dlt_tables():
             for record in records: