Skip to content

Commit

Permalink
ignores typing errors
Browse files Browse the repository at this point in the history
  • Loading branch information
willi-mueller committed Aug 7, 2024
1 parent d4b8b68 commit 7feef42
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/extract/test_incremental.py
Original file line number Diff line number Diff line change
Expand Up @@ -835,14 +835,14 @@ def some_data(
assert e.value.json_path == "created_at"

# same thing when run in pipeline
with pytest.raises(PipelineStepFailed) as e:
with pytest.raises(PipelineStepFailed) as e: # type: ignore[assignment]
p = dlt.pipeline(pipeline_name=uniq_id())
p.extract(some_data())
if item_type == "object":
assert isinstance(e.value.__context__, IncrementalCursorPathMissing)
else:
assert isinstance(e.value.__context__, IncrementalCursorPathHasValueNone)
assert e.value.__context__.json_path == "created_at"
assert e.value.__context__.json_path == "created_at" # type: ignore[attr-defined]


@pytest.mark.parametrize("item_type", ["arrow-table", "arrow-batch", "pandas"])
Expand All @@ -868,7 +868,7 @@ def some_data(
with pytest.raises(PipelineStepFailed) as pip_ex:
p = dlt.pipeline(pipeline_name=uniq_id())
p.extract(some_data())
assert pip_ex.value.__context__.json_path == "created_at"
assert pip_ex.value.__context__.json_path == "created_at" # type: ignore[assignment]
assert isinstance(pip_ex.value.__context__, IncrementalCursorPathMissing)


Expand Down

0 comments on commit 7feef42

Please sign in to comment.