fix some tests for sqlalchemy 1.4

dlt-hub · Sep 5, 2024 · 7264799 · 7264799
1 parent 3427cc8
commit 7264799
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/tests/load/sources/sql_database/test_sql_database_source.py b/tests/load/sources/sql_database/test_sql_database_source.py
@@ -407,7 +407,7 @@ def test_type_adapter_callback(
     def conversion_callback(t):
         if isinstance(t, sa.JSON):
             return sa.Text
-        elif isinstance(t, sa.Double):  # type: ignore[attr-defined]
+        elif hasattr(sa, "Double") and isinstance(t, sa.Double):  # type: ignore[attr-defined]
             return sa.BIGINT
         return t
 
@@ -436,7 +436,11 @@ def conversion_callback(t):
     schema = pipeline.default_schema
     table = schema.tables["has_precision"]
     assert table["columns"]["json_col"]["data_type"] == "text"
-    assert table["columns"]["float_col"]["data_type"] == "bigint"
+    assert (
+        table["columns"]["float_col"]["data_type"] == "bigint"
+        if hasattr(sa, "Double")
+        else "double"
+    )
 
 
 @pytest.mark.parametrize("backend", ["sqlalchemy", "pyarrow", "pandas", "connectorx"])