Skip to content

Commit

Permalink
style: indentation
Browse files Browse the repository at this point in the history
  • Loading branch information
joscha committed Dec 9, 2024
1 parent 0605d80 commit 6fa2e06
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
6 changes: 5 additions & 1 deletion dlt/common/schema/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,11 @@ def diff_table(
partial_table[k] = v # type: ignore

# this should not really happen
if is_nested_table(tab_a) and (resource := tab_b.get("resource")) and resource != tab_a.get("parent"):
if (
is_nested_table(tab_a)
and (resource := tab_b.get("resource"))
and resource != tab_a.get("parent")
):
raise TablePropertiesConflictException(
schema_name, table_name, "resource", resource, tab_a.get("parent")
)
Expand Down
10 changes: 5 additions & 5 deletions tests/pipeline/test_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -666,17 +666,16 @@ def with_table_hints():
# check table counts
assert_data_table_counts(pipeline, {"table_a": 2, "table_b": 2, "table_c": 1})


def test_mark_parent_table() -> None:
@dlt.resource()
def my_table():
yield {"id": 1}
yield dlt.mark.with_hints(
{"id": 10},
dlt.mark.make_hints(
table_name="my_other_table",
parent_table_name="my_table"
),
dlt.mark.make_hints(table_name="my_other_table", parent_table_name="my_table"),
)

pipeline_name = "pipe_" + uniq_id()
pipeline = dlt.pipeline(pipeline_name=pipeline_name, destination="duckdb")
info = pipeline.run(my_table)
Expand All @@ -687,7 +686,8 @@ def my_table():
"my_other_table": 1,
}
# check table counts
assert_data_table_counts(pipeline, {"my_table": 1, "my_other_table": 1 })
assert_data_table_counts(pipeline, {"my_table": 1, "my_other_table": 1})


def test_restore_state_on_dummy() -> None:
pipeline_name = "pipe_" + uniq_id()
Expand Down

0 comments on commit 6fa2e06

Please sign in to comment.