Skip to content

Commit

Permalink
some cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
sh-rp committed Sep 5, 2024
1 parent c02e87b commit 55c135d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion dlt/destinations/impl/mssql/sql_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def drop_dataset(self) -> None:
table_names = [row[0] for row in rows]
self.drop_tables(*table_names)
# Drop schema
# self._drop_schema()
self._drop_schema()

def _drop_views(self, *tables: str) -> None:
if not tables:
Expand Down
2 changes: 0 additions & 2 deletions tests/pipeline/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,6 @@ def assert_schema_on_data(
assert actual_dt == expected_dt

if requires_nulls:
print(columns_with_nulls)
print(set(col["name"] for col in table_columns.values() if col["nullable"]))
# make sure that all nullable columns in table received nulls
assert (
set(col["name"] for col in table_columns.values() if col["nullable"])
Expand Down

0 comments on commit 55c135d

Please sign in to comment.