Fix tests

dlt-hub · Aug 26, 2024 · 23b6f4e · 23b6f4e
1 parent 227c89c
commit 23b6f4e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/dlt/destinations/impl/bigquery/bigquery.py b/dlt/destinations/impl/bigquery/bigquery.py
@@ -229,9 +229,7 @@ def __init__(
             config.http_timeout,
             config.retry_deadline,
         )
-        SupportsStagingDestination.__init__(
-            self, config.truncate_table_before_load_on_staging_destination
-        )
+        SupportsStagingDestination.__init__(self, config)
         super().__init__(schema, config, sql_client)
         self.config: BigQueryClientConfiguration = config
         self.sql_client: BigQuerySqlClient = sql_client  # type: ignore

diff --git a/dlt/destinations/impl/dummy/configuration.py b/dlt/destinations/impl/dummy/configuration.py
@@ -4,7 +4,7 @@
 from dlt.common.configuration import configspec
 from dlt.common.destination import TLoaderFileFormat
 from dlt.common.destination.reference import (
-    DestinationClientConfiguration,
+    DestinationClientDwhWithStagingConfiguration,
     CredentialsConfiguration,
 )
 
@@ -16,7 +16,7 @@ def __str__(self) -> str:
 
 
 @configspec
-class DummyClientConfiguration(DestinationClientConfiguration):
+class DummyClientConfiguration(DestinationClientDwhWithStagingConfiguration):
     destination_type: Final[str] = dataclasses.field(default="dummy", init=False, repr=False, compare=False)  # type: ignore
     loader_file_format: TLoaderFileFormat = "jsonl"
     fail_schema_update: bool = False
@@ -36,6 +36,8 @@ class DummyClientConfiguration(DestinationClientConfiguration):
     """raise transient exception in job init"""
     truncate_table_before_load_on_staging_destination: bool = True
     """truncate tables on staging destination"""
+    dataset_name: str = "dummy"
+    """dummy dataset name"""
 
     # new jobs workflows
     create_followup_jobs: bool = False

diff --git a/tests/load/test_dummy_client.py b/tests/load/test_dummy_client.py
@@ -558,7 +558,7 @@ def test_truncate_table_before_load_on_stanging(to_truncate) -> None:
     load_id, schema = prepare_load_package(load.load_storage, NORMALIZED_FILES)
     destination_client = load.get_destination_client(schema)
     assert (
-        destination_client.should_truncate_table_before_load_on_staging_destination(
+        destination_client.should_truncate_table_before_load_on_staging_destination(  # type: ignore
             schema.tables["_dlt_version"]
         )
         == to_truncate