Skip to content

Commit

Permalink
fixes more tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rudolfix committed Sep 8, 2024
1 parent 16d41c6 commit 1a57a19
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test_common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ jobs:
name: Run pipeline tests with pyarrow but no pandas installed Windows
shell: cmd
- name: create secrets.toml for examples
run: pwd && echo "$DLT_SECRETS_TOML" > tests/.dlt/secrets.toml
# - name: create secrets.toml for examples
# run: pwd && echo "$DLT_SECRETS_TOML" > tests/.dlt/secrets.toml

- name: Install pipeline and sources dependencies
run: poetry install --no-interaction -E duckdb -E cli -E parquet -E deltalake -E sql_database --with sentry-sdk,pipeline,sources
Expand Down
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ mimesis = "^7.0.0"
optional = true
[tool.poetry.group.sources.dependencies]
connectorx = [
{version = "0.3.2", python = "^3.8", optional = true},
{version = ">=0.3.2", python = ">=3.9", optional = true}
{version = "0.3.2", python = "^3.8"},
{version = ">=0.3.2", python = ">=3.9"}
]
pymysql = "^1.1.0"
openpyxl = "^3"
Expand Down
11 changes: 6 additions & 5 deletions tests/load/sources/sql_database/test_sql_database_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -969,11 +969,12 @@ def assert_row_counts(
tables: Optional[List[str]] = None,
include_views: bool = False,
) -> None:
tables = [
tbl_name
for tbl_name, info in sql_source_db.table_infos.items()
if include_views or not info["is_view"]
]
if not tables:
tables = [
tbl_name
for tbl_name, info in sql_source_db.table_infos.items()
if include_views or not info["is_view"]
]
dest_counts = load_table_counts(pipeline, *tables)
for table in tables:
info = sql_source_db.table_infos[table]
Expand Down

0 comments on commit 1a57a19

Please sign in to comment.