-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add '@rollup/plugin-esm-shim' #123
Merged
+103
−1
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c4f0b5b
Add '@rollup/plugin-esm-shim'
Peeterush 83f7966
Add test for dist files
Peeterush 4a6978b
Add test-dist to the build.
Peeterush 00d0d00
Remove clearBuildInfo() for Github
Peeterush 2160b79
Remove 'vite build' from 'test-dist'
Peeterush 3088496
Use features instead of version for build verification.
Peeterush 50d21ab
Update @rollup/plugin-esm-shim
Peeterush 67b84af
Merge branch 'main' into main
dlemstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,5 +5,5 @@ publish/etc | |
publish/*.tgz | ||
tools/*.js | ||
issue/*.js | ||
dist | ||
/dist | ||
NOTICE |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Copyright Dirk Lemstra https://github.com/dlemstra/magick-wasm. | ||
// Licensed under the Apache License, Version 2.0. | ||
|
||
const { initializeImageMagick, Magick } = require('../../dist/index.umd.js'); | ||
|
||
const wasmLocation = '../../node_modules/@dlemstra/magick-native/magick.wasm'; | ||
|
||
initializeImageMagick(wasmLocation).then(() => { | ||
console.log(Magick.imageMagickVersion); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Copyright Dirk Lemstra https://github.com/dlemstra/magick-wasm. | ||
// Licensed under the Apache License, Version 2.0. | ||
|
||
import { initializeImageMagick, Magick } from '../../dist/index.mjs'; | ||
|
||
const wasmLocation = '../../node_modules/@dlemstra/magick-native/magick.wasm'; | ||
|
||
initializeImageMagick(wasmLocation).then(() => { | ||
console.log(Magick.imageMagickVersion); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// Copyright Dirk Lemstra https://github.com/dlemstra/magick-wasm. | ||
// Licensed under the Apache License, Version 2.0. | ||
|
||
const util = require('node:util'); | ||
const exec = util.promisify(require('node:child_process').exec); | ||
|
||
const colorReset = '\x1b[0m'; | ||
const colorGreen = '\x1b[32m'; | ||
const colorRed = '\x1b[31m'; | ||
|
||
const versionRegEx = | ||
/^ImageMagick \d+\.\d+\.\d+-\d+ Q8 x86_64 [\w\d]+:[\w\d]+ https:\/\/imagemagick\.org$/; | ||
|
||
let foundError = false; | ||
|
||
async function runTest(filename) { | ||
try { | ||
return await exec(`node ${filename}`); | ||
} catch (error) { | ||
return { | ||
stdout: '', | ||
stderr: error.stderr, | ||
}; | ||
} | ||
} | ||
|
||
async function testDistFile(filename) { | ||
const { stdout, stderr } = await runTest(filename); | ||
|
||
const name = filename.substring(5, 8); | ||
|
||
if (stdout.trim().match(versionRegEx)) { | ||
console.log(`${colorGreen}${name} build passed${colorReset}`); | ||
return; | ||
} | ||
|
||
foundError = true; | ||
|
||
console.error(`${colorRed}${name} build failed:${colorReset}`); | ||
console.error( | ||
stderr || `"${stdout.trim()}"\ndoes not match\n${versionRegEx}` | ||
); | ||
} | ||
|
||
async function testDist() { | ||
console.log(''); | ||
|
||
await testDistFile('test-ESM.mjs'); | ||
await testDistFile('test-CJS.js'); | ||
|
||
if (foundError) process.exit(1); | ||
|
||
console.log(''); | ||
} | ||
|
||
testDist(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also use the
features
here instead so we don't need a regex?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!