-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Implement the ability to mock the registry too #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5259464 bin/dub
-rough build time=63s
+rough build time=62s Full build output
|
thewilsonator
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, mind the test suite failures though
PR 2926 added the possibility that '*' is serialized to PackageRecipe instead of '>=0.0.0' but we need the parser to handle it.
`Package.storeInfo` does IO directly which conflicts with our dependency injection approach. Instead inline the code and use `this.writeFile` directly.
The `dub.internal.utils : lockFile` function does not land itself to mocking quite well, as it exposes a struct containing a `std.stdio : File` instance. The path of least resistance, for now, is to access `store_` directly from TestPackageManager by overriding `store`.
Otherwise we are not able to write the entries in a Zip file, as we get an exception from std.zip. This is a workaround and a proper fix would be to implement a Clock system.
So far tests have limited themselves to the local state, but we want to expand them to test the behavior of dub when fetching packages, so we need a convenient way to add packages to the registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally implemented the fix for #2901 using this before settling on the much simpler unittest.
Here's what the test would have looked like: