-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VersionRange: Always output minor version for ~> and ^ #2928
Conversation
Dub was correct in outputting only the major version, however this can lead to some confusion for users as pointed out in dlang#2830. Accepting ~>5 but only exposing two states (~>5.0 and ~>5.0.0) will hopefully make things a bit more obvious.
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5259464 bin/dub
-rough build time=62s
+rough build time=61s Full build output
|
I'd say the way you have it in the unit tests makes most sense. Following the general scheme, |
@s-ludwig : Anything else to do for now ? We probably want to deprecate it later but I don't think it's urgent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go for now!
@s-ludwig : I was about to close #2830 as WONTFIX but thinking about it more reducing possible state is probably best. Thoughts ?