Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionRange: Always output minor version for ~> and ^ #2928

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jun 11, 2024

Dub was correct in outputting only the major version, however this can lead to some confusion for users
as pointed out in 2830. Accepting ~>5 but only exposing two states (~>5.0 and ~>5.0.0) will hopefully make things a bit more obvious.

@s-ludwig : I was about to close #2830 as WONTFIX but thinking about it more reducing possible state is probably best. Thoughts ?

@Geod24 Geod24 requested a review from s-ludwig June 11, 2024 12:42
Dub was correct in outputting only the major version,
however this can lead to some confusion for users
as pointed out in dlang#2830. Accepting ~>5 but only exposing
two states (~>5.0 and ~>5.0.0) will hopefully make
things a bit more obvious.
Copy link

github-actions bot commented Jun 11, 2024

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
 executable size=5259464 bin/dub
-rough build time=62s
+rough build time=61s
Full build output
DUB version 1.37.0, built on May 11 2024
LDC - the LLVM D compiler (1.38.0):
  based on DMD v2.108.1 and LLVM 18.1.5
  built with LDC - the LLVM D compiler (1.38.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.38.0/x64/ldc2-1.38.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.38.0+commit.40.gd914dc0c: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5259464 bin/dub
STAT:rough build time=61s

@s-ludwig
Copy link
Member

I'd say the way you have it in the unit tests makes most sense. Following the general scheme, ~>1 would be the same as >=1.0.0, which doesn't really mean anything useful in SemVer semantics, so IMO, we shouldn't advertise it as a supported syntax, and neither output it. Disallowing it completely might be subject to a deprecation phase, though, considering that people might have picked up on it.

@Geod24
Copy link
Member Author

Geod24 commented Jun 11, 2024

@s-ludwig : Anything else to do for now ? We probably want to deprecate it later but I don't think it's urgent.

Copy link
Member

@s-ludwig s-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go for now!

@s-ludwig s-ludwig merged commit 45a6b6f into dlang:master Jun 11, 2024
31 checks passed
@Geod24 Geod24 deleted the mlang/Fix2830 branch June 11, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dub add breaks ~>x.0 dependency specification
2 participants