-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Make PackageManager.lookup() not call refresh() #2883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5356064 bin/dub
-rough build time=60s
+executable size=5433960 bin/dub
+rough build time=59s Full build output
|
nordlow
force-pushed
the
avoid-refresh
branch
2 times, most recently
from
February 27, 2024 17:24
5c2baa3
to
5e14a89
Compare
nordlow
changed the title
WIP: Make PackageManager.lookup() lazy
WIP: Make PackageManager.lookup() not call refresh()
Feb 28, 2024
nordlow
changed the title
WIP: Make PackageManager.lookup() not call refresh()
Draft: Make PackageManager.lookup() not call refresh()
Feb 28, 2024
nordlow
force-pushed
the
avoid-refresh
branch
from
February 29, 2024 11:53
5e14a89
to
e5de6de
Compare
nordlow
force-pushed
the
avoid-refresh
branch
from
February 29, 2024 12:16
e5de6de
to
8a2a4f8
Compare
nordlow
force-pushed
the
avoid-refresh
branch
from
February 29, 2024 17:13
bdc839e
to
c2b29e1
Compare
Done in #2923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding MR to trigger CI to see if anything breaks.
At least
dub build --compiler=dmd && DC=dmd DUB=bin/dub test/run-unittest.sh
passes locally.