Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft Abstract Staking logic #83

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Draft Abstract Staking logic #83

merged 13 commits into from
Jan 23, 2024

Conversation

mllwchrry
Copy link
Contributor

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f7b2b6) 100.00% compared to head (338f93d) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        45    +2     
  Lines         1726      1820   +94     
  Branches       253       269   +16     
=========================================
+ Hits          1726      1820   +94

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arvolear Arvolear marked this pull request as ready for review January 17, 2024 19:50
@dovgopoly dovgopoly self-requested a review January 18, 2024 10:49
dovgopoly
dovgopoly reviewed Jan 18, 2024
View reviewed changes
contracts/staking/AbstractValueDistributor.sol Outdated Show resolved Hide resolved
contracts/staking/AbstractValueDistributor.sol Outdated Show resolved Hide resolved
contracts/staking/AbstractValueDistributor.sol Outdated Show resolved Hide resolved
contracts/staking/AbstractValueDistributor.sol Outdated Show resolved Hide resolved
Arvolear
Arvolear approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit c76706a into master Jan 23, 2024
4 checks passed
@Arvolear Arvolear deleted the feat/abstract-staking branch January 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dovgopoly dovgopoly dovgopoly left review comments

@Hrom131 Hrom131 Hrom131 left review comments

@Arvolear Arvolear Arvolear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mllwchrry @Hrom131 @Arvolear @dovgopoly