Feat/rpow function #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aritkulova
commented
Oct 23, 2023
•
aritkulova
commented
- Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
Added private function _rpow to AbstractCompoundRateKeeper
Make func internal for test reasons
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 39 -1
Lines 1658 1662 +4
Branches 232 234 +2
=========================================
+ Hits 1658 1662 +4
☔ View full report in Codecov by Sentry. |
Check if base or exponent equal to 0 removed
dovgopoly
reviewed
Oct 25, 2023
dovgopoly
reviewed
Oct 25, 2023
Arvolear
reviewed
Oct 26, 2023
rpow is renamed to raiseToPower precision taken not as func parameter but from the global scope upd to version 2.6.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.