Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added impl param #70

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Added impl param #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e820e7
bumped version
dovgopoly Oct 13, 2023
a07c3e3
added impl param
dovgopoly Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contracts/contracts-registry/pools/AbstractPoolContractsRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend
) internal virtual {
for (uint256 i = 0; i < names_.length; i++) {
if (address(_beacons[names_[i]]) == address(0)) {
_beacons[names_[i]] = ProxyBeacon(_deployProxyBeacon());
_beacons[names_[i]] = ProxyBeacon(_deployProxyBeacon(newImplementations_[i]));
}

if (_beacons[names_[i]].implementation() != newImplementations_[i]) {
Expand Down Expand Up @@ -184,9 +184,10 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend

/**
* @notice The utility function to deploy a Proxy Beacon contract to be used within the registry
* @param implementation_ the address of the implementation
* @return the address of a Proxy Beacon
*/
function _deployProxyBeacon() internal virtual returns (address) {
function _deployProxyBeacon(address implementation_) internal virtual returns (address) {
return address(new ProxyBeacon());
}
}
2 changes: 1 addition & 1 deletion contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solarity/solidity-lib",
"version": "2.6.2",
"version": "2.6.3",
"license": "MIT",
"author": "Distributed Lab",
"readme": "README.md",
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solarity/solidity-lib",
"version": "2.6.2",
"version": "2.6.3",
"license": "MIT",
"author": "Distributed Lab",
"description": "Solidity Library by Distributed Lab",
Expand Down