Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC165 to the SBT contract #69

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

Hrom131
Copy link
Member

@Hrom131 Hrom131 commented Oct 12, 2023

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@Hrom131 Hrom131 requested a review from Arvolear October 12, 2023 12:13
@Hrom131 Hrom131 self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (abb78ee) 100.00% compared to head (2d37c63) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         1482      1487    +5     
  Branches       193       196    +3     
=========================================
+ Hits          1482      1487    +5     
Files Coverage Δ
contracts/tokens/SBT.sol 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit dc27299 into master Oct 12, 2023
4 checks passed
@Arvolear Arvolear deleted the feat/SBT_supports_interface branch October 12, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants