Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC721 diamond #68

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Add ERC721 diamond #68

merged 9 commits into from
Oct 20, 2023

Conversation

joYyHack
Copy link
Contributor

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@joYyHack joYyHack requested a review from Arvolear October 11, 2023 00:10
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abb78ee) 100.00% compared to head (618a807) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master       #68    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           38        40     +2     
  Lines         1482      1658   +176     
  Branches       193       232    +39     
==========================================
+ Hits          1482      1658   +176     
Files Coverage Δ
...cts/contracts-registry/pools/proxy/ProxyBeacon.sol 100.00% <100.00%> (ø)
contracts/diamond/tokens/ERC721/DiamondERC721.sol 100.00% <100.00%> (ø)
...cts/diamond/tokens/ERC721/DiamondERC721Storage.sol 100.00% <100.00%> (ø)
contracts/tokens/SBT.sol 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arvolear
Copy link
Member

Please update 2 package.jsons versions. Let's use 2.6.5

Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit dc6dff0 into master Oct 20, 2023
4 checks passed
@Arvolear Arvolear deleted the feat/ERC721Diamond branch October 20, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants