Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diamond refactor #65

Merged
merged 14 commits into from
Oct 9, 2023
Merged

Diamond refactor #65

merged 14 commits into from
Oct 9, 2023

Conversation

joYyHack
Copy link
Contributor

@joYyHack joYyHack commented Oct 3, 2023

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@joYyHack joYyHack requested review from Arvolear and dovgopoly October 3, 2023 08:46
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (28e7045) 100.00% compared to head (1586cfd) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        37    +1     
  Lines         1342      1387   +45     
  Branches       163       179   +16     
=========================================
+ Hits          1342      1387   +45
Files Coverage Δ
contracts/diamond/Diamond.sol 100.00% <100.00%> (ø)
contracts/diamond/DiamondStorage.sol 100.00% <100.00%> (ø)
contracts/diamond/introspection/DiamondERC165.sol 100.00% <100.00%> (ø)
.../diamond/presets/OwnableDiamond/OwnableDiamond.sol 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Arvolear
Arvolear approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit fe21d37 into master Oct 9, 2023
@Arvolear Arvolear deleted the feat/DiamondRefactor branch October 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arvolear Arvolear Arvolear approved these changes

@dovgopoly dovgopoly Awaiting requested review from dovgopoly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joYyHack @Arvolear