Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Oracle contract #59

Merged
merged 26 commits into from
Oct 10, 2023
Merged

Added Oracle contract #59

merged 26 commits into from
Oct 10, 2023

Conversation

aritkulova
Copy link
Contributor

@aritkulova aritkulova commented Jul 26, 2023 •
edited by Arvolear
Loading

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

WIP, do not merge

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (28e7045) 100.00% compared to head (6e69d28) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##            master       #59    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           36        38     +2     
  Lines         1342      1472   +130     
  Branches       163       192    +29     
==========================================
+ Hits          1342      1472   +130
Files Coverage Δ
contracts/oracles/UniswapV2Oracle.sol 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aritkulova aritkulova changed the title Added PriceFeedOracle contract Added Oracle contract Sep 19, 2023
@aritkulova aritkulova marked this pull request as ready for review September 20, 2023 16:03
KyrylR
KyrylR approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@KyrylR KyrylR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Arvolear Arvolear merged commit d11716f into master Oct 10, 2023
2 checks passed
@Arvolear Arvolear deleted the feat/oracle branch October 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dovgopoly dovgopoly dovgopoly left review comments

@RuslanProgrammer RuslanProgrammer RuslanProgrammer left review comments

@Arvolear Arvolear Arvolear left review comments

@Hrom131 Hrom131 Hrom131 left review comments

@KyrylR KyrylR KyrylR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aritkulova @Hrom131 @Arvolear @RuslanProgrammer @dovgopoly @KyrylR