Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base CMT implementation #121

Merged
merged 14 commits into from
Dec 11, 2024
Merged

Add base CMT implementation #121

merged 14 commits into from
Dec 11, 2024

Conversation

Hrom131
Copy link
Member

@Hrom131 Hrom131 commented Dec 2, 2024

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@Hrom131 Hrom131 requested a review from Arvolear December 2, 2024 16:38
@Hrom131 Hrom131 self-assigned this Dec 2, 2024
@Hrom131 Hrom131 marked this pull request as ready for review December 11, 2024 11:14
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (79f75d8) to head (e95bfae).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   99.80%   99.75%   -0.05%     
==========================================
  Files          55       56       +1     
  Lines        3051     3278     +227     
  Branches      449      489      +40     
==========================================
+ Hits         3045     3270     +225     
- Misses          6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 3585f10 into master Dec 11, 2024
2 checks passed
@Arvolear Arvolear deleted the feature/CMT branch December 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants