Crypto libs #115
Merged
Crypto libs #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Arvolear
commented
Nov 12, 2024
Arvolear
commented
- Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
Arvolear
force-pushed
the
feat/crypto
branch
from
5c38695 to
b4e4ded
Compare
Arvolear
force-pushed
the
feat/crypto
branch
from
b4e4ded to
8992508
Compare
Arvolear
commented
Nov 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
===========================================
- Coverage 100.00% 99.79% -0.21%
===========================================
Files 50 54 +4
Lines 2295 2969 +674
Branches 365 440 +75
===========================================
+ Hits 2295 2963 +668
- Misses 0 6 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Arvolear
added a commit
that referenced
this pull request
Nov 20, 2024
* Crypto libs (#115) * added ecdsa384 lib * added rsassapss * try fix ci * fix callvalue * Added tests covering the `verify` and `_isOnCurve` functions * fix coverage * split getModifiedSigOrPubKey into modifyLeft and modifyRight * Added tests covering the RSASSAPSS lib * switched to assert two unreachable conditions * fixed typos in test * removed unused functions in U384 lib * added test for a U384.cmp function * trying to fix test for cmp * add brainpoolP384r1 test --------- Co-authored-by: aritkulova <[email protected]> * updated crypto lib contracts: - pragma solidity; - solhint; - custom errors * updated missed pragma solidity * fixed typo in README --------- Co-authored-by: Artem Chystiakov <[email protected]>
Arvolear
added a commit
that referenced
this pull request
Dec 3, 2024
* Crypto libs (#115) * added ecdsa384 lib * added rsassapss * try fix ci * fix callvalue * Added tests covering the `verify` and `_isOnCurve` functions * fix coverage * split getModifiedSigOrPubKey into modifyLeft and modifyRight * Added tests covering the RSASSAPSS lib * switched to assert two unreachable conditions * fixed typos in test * removed unused functions in U384 lib * added test for a U384.cmp function * trying to fix test for cmp * add brainpoolP384r1 test --------- Co-authored-by: aritkulova <[email protected]> * updated crypto lib contracts: - pragma solidity; - solhint; - custom errors * updated missed pragma solidity * fixed typo in README --------- Co-authored-by: Artem Chystiakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.