Skip to content

Commit

Permalink
fixes (#71)
Browse files Browse the repository at this point in the history
  • Loading branch information
dovgopoly authored Oct 16, 2023
1 parent 067e616 commit 914f4c1
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend
) internal virtual {
for (uint256 i = 0; i < names_.length; i++) {
if (address(_beacons[names_[i]]) == address(0)) {
_beacons[names_[i]] = ProxyBeacon(_deployProxyBeacon(newImplementations_[i]));
_beacons[names_[i]] = ProxyBeacon(_deployProxyBeacon());
}

if (_beacons[names_[i]].implementation() != newImplementations_[i]) {
Expand Down Expand Up @@ -184,10 +184,9 @@ abstract contract AbstractPoolContractsRegistry is Initializable, AbstractDepend

/**
* @notice The utility function to deploy a Proxy Beacon contract to be used within the registry
* @param implementation_ the address of the implementation
* @return the address of a Proxy Beacon
*/
function _deployProxyBeacon(address implementation_) internal virtual returns (address) {
function _deployProxyBeacon() internal virtual returns (address) {
return address(new ProxyBeacon());
}
}
2 changes: 1 addition & 1 deletion contracts/contracts-registry/pools/proxy/ProxyBeacon.sol
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ contract ProxyBeacon is IBeacon {
emit Upgraded(newImplementation_);
}

function implementation() external view override returns (address) {
function implementation() public view override returns (address) {
return _implementation;
}
}
2 changes: 1 addition & 1 deletion contracts/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solarity/solidity-lib",
"version": "2.6.3",
"version": "2.6.4",
"license": "MIT",
"author": "Distributed Lab",
"readme": "README.md",
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solarity/solidity-lib",
"version": "2.6.3",
"version": "2.6.4",
"license": "MIT",
"author": "Distributed Lab",
"description": "Solidity Library by Distributed Lab",
Expand Down

0 comments on commit 914f4c1

Please sign in to comment.