Add deployment arguments validation before the contract deployment

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 2.1.2
+
+* Added deployment arguments validation before the contract deployment.
+
 ## Version 2.1.1
 
 * Fixed a bug related to the shallow copying and mutation of arguments within the `getMethodString` function.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solarity/hardhat-migrate",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "Automatic deployment and verification of smart contracts",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

src/deployer/MinimalContract.ts

@@ -139,6 +139,14 @@ export class MinimalContract {
       return;
     }
 
+    const factory = new ethers.ContractFactory(this._interface, this._bytecode);
+
+    const coder = new ethers.AbiCoder();
+    // Try to encode the arguments before sending the deployment transaction
+    factory.interface.deploy.inputs.forEach((input, idx) => {
+      coder.encode([input], [args[idx]]);
+    });
+
     VerificationProcessor.saveVerificationFunction({
       contractAddress,
       contractName: contractName,

src/utils/common.ts

@@ -1,5 +1,6 @@
 import { join } from "path";
 import { realpathSync, existsSync } from "fs";
+
 import { UNKNOWN_CONTRACT_NAME } from "../constants";
 
 export function resolvePathToFile(path: string, file: string = ""): string {

test/fixture-projects/hardhat-project-typechain-ethers/contracts/TestContracts.sol

@@ -19,4 +19,8 @@ contract PayableReceive {
     receive() external payable {
         emit Received(msg.sender, msg.value);
     }
+
+    function pay() external payable {
+        emit Received(msg.sender, msg.value);
+    }
 }

test/integration/deployer/base-contract-interaction.ts

@@ -5,6 +5,7 @@ import { useEnvironment } from "../../helpers";
 import {
   ConstructorWithArguments__factory,
   PayableConstructor__factory,
+  PayableReceive__factory,
 } from "../../fixture-projects/hardhat-project-typechain-ethers/typechain-types";
 
 import { Deployer } from "../../../src/deployer/Deployer";
@@ -41,10 +42,28 @@ describe("deployer", () => {
       expect(await ethersProvider!.provider.getBalance(contract.getAddress())).to.equal(toPay);
     });
 
+    it("should not deploy contract with invalid constructor arguments", async function () {
+      const signer = (await deployer.getSigner()) as any;
+
+      await expect(deployer.deploy(ConstructorWithArguments__factory, [signer], {})).to.be.rejectedWith(
+        `Deployer.deploy(): MinimalContract.deploy(): MinimalContract._createDeployTransaction(): invalid BigNumberish value (argument="value", value="<SignerWithAddress 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266>", code=INVALID_ARGUMENT, version=6.10.0)`,
+      );
+    });
+
     it("should revert if artifact is not a contract", async function () {
       await expect(deployer.deploy({} as any, [], {})).to.be.rejectedWith(
         "Deployer.deploy(): Unknown Contract Factory Type",
       );
     });
+
+    it("should be able to customize overrides for function calls", async function () {
+      const contract = await deployer.deploy(PayableReceive__factory);
+
+      const toPay = 100n;
+
+      await contract.pay({ value: toPay.toString() });
+
+      expect(await ethersProvider!.provider.getBalance(contract.getAddress())).to.equal(toPay);
+    });
   });
 });