refactor

dl-solarity · Nov 2, 2023 · e4c4d30 · e4c4d30
1 parent c090119
commit e4c4d30
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/deployer/Deployer.ts b/src/deployer/Deployer.ts
@@ -27,22 +27,19 @@ export class Deployer {
 
   public async deploy<T, A = T, I = any>(
     contract: Instance<A, I> | (T extends Truffle.Contract<I> ? T : never),
-    argsOrParameters: TypedArgs<A> | OverridesAndLibs = {},
+    argsOrParameters: OverridesAndLibs | TypedArgs<A> = [] as TypedArgs<A>,
     parameters: OverridesAndLibs = {},
   ): Promise<I> {
     const adapter = this._resolveAdapter(contract);
-
     const minimalContract = await adapter.fromInstance(contract, parameters);
 
-    let contractAddress: string;
-    if (argsOrParameters instanceof Array) {
-      contractAddress = await minimalContract.deploy(argsOrParameters, parameters);
-    } else if (argsOrParameters instanceof Object) {
-      contractAddress = await minimalContract.deploy([], argsOrParameters);
-    } else {
-      contractAddress = await minimalContract.deploy([], {});
+    if (!(argsOrParameters instanceof Array)) {
+      parameters = argsOrParameters;
+      argsOrParameters = [] as TypedArgs<A>;
     }
 
+    const contractAddress = await minimalContract.deploy(argsOrParameters as TypedArgs<A>, parameters);
+
     return adapter.toInstance(contract, contractAddress, parameters);
   }