#136 UniversalDecompressor hard-codes configuration file location #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzo1
reviewed
Nov 9, 2023
...pl-wikimachine/src/main/java/org/dkpro/jwpl/wikimachine/decompression/BZip2Decompressor.java
Outdated
Show resolved
Hide resolved
- removes the hardcoded string PROPERTIES_PATH from `UniversalDecompressor` - adds a new constructor to `UniversalDecompressor` taking a Path reference for custom XML file configs - adds new test class `UniversalDecompressorTest`, previously totally untested - demonstrates the handling of custom `ar` archive approach via decompressor-ar.xml, as 7z is not present on many platforms by default - adjusts GZipDecompressor / BZip2Decompressor to check both ways to read an archive: classpath or external (file) location - resolves #136
mawiesne
force-pushed
the
#136-UniversalDecompressor-hard-codes-configuration-file-location
branch
from
2382c1f to
675feeb
Compare
rzo1
approved these changes
Nov 14, 2023
|
Ping @logological |
|
@mawiesne Sorry, I'm no longer qualified to review this patch—I opened the original issue 8 years ago and my understanding of it (and the underlying code) has faded. |
Nevermind. Thanks for reporting back so quickly. |
mawiesne
deleted the
#136-UniversalDecompressor-hard-codes-configuration-file-location
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UniversalDecompressorUniversalDecompressortaking a Path reference for custom XML file configsUniversalDecompressorTest, previously totally untestedararchive approach via decompressor-ar.xml, as 7z is not present on many platforms by defaultWhat's in the PR
How to test manually
mvn clean testAutomatic testing
Documentation