Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#124 PageQueryIterable doesn't escape special characters #272

Merged

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Nov 6, 2023

  • switches to named parameters in PageQueryIterable instead of param concatenation
  • adds new test class PageQueryIterableTest to demonstrate the handling of ' characters with "Moore's law" as example
  • adjusts existing test cases to reflect the added data element in the TestDB script

What's in the PR

How to test manually

  • mvn clean test

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- switches to named parameters in `PageQueryIterable` instead of param concatenation
- adds new test class `PageQueryIterableTest` to demonstrate the handling of `'` characters with "Moore's law" as example
- adjusts existing test cases to reflect the added data element in the TestDB script
@mawiesne mawiesne requested review from reckart and rzo1 November 6, 2023 14:58
@mawiesne mawiesne self-assigned this Nov 6, 2023
@mawiesne mawiesne added this to the 2.0.0 milestone Nov 6, 2023
@mawiesne mawiesne merged commit 153d748 into master Nov 9, 2023
4 checks passed
@mawiesne mawiesne deleted the #124-PageQueryIterable-doesn't-escape-special-characters branch November 9, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageQueryIterable doesn't escape special characters
2 participants