Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#249 Remove commons-codec dependency in favor of JDK's own Base64 codec #250

Merged
merged 1 commit into from
Oct 30, 2023
Merged

#249 Remove commons-codec dependency in favor of JDK's own Base64 codec #250

merged 1 commit into from
Oct 30, 2023

Conversation

mawiesne
Copy link
Contributor

  • switches to java.util.Base64 instead of org.apache.commons.codec.binary.Base64
  • removes (hard) dependency commons-codec from dkpro-jwpl-revisionmachine

@mawiesne
#249 Remove commons-codec dependency in favor of JDK's own Base64 codec
7d9f4a4 
- switches to `java.util.Base64` instead of `org.apache.commons.codec.binary.Base64`
- removes (hard) dependency commons-codec from `dkpro-jwpl-revisionmachine`
@mawiesne mawiesne added this to the 2.0.0 milestone Oct 29, 2023
@mawiesne mawiesne requested a review from rzo1 October 29, 2023 20:35
@mawiesne mawiesne self-assigned this Oct 29, 2023
@mawiesne mawiesne added the dependencies Pull requests that update a dependency file label Oct 29, 2023
@mawiesne mawiesne merged commit 600d287 into master Oct 30, 2023
6 checks passed
@mawiesne mawiesne deleted the #249-remove-commons-codec-dependency-in-favor-of-JDK's-own-Base64-codec branch October 30, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzo1 rzo1 rzo1 approved these changes

Assignees

@mawiesne mawiesne

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mawiesne @rzo1