#245 Remove unused method binding to commons.io dependency in API mod…

…ule (#246)
dkpro · Oct 29, 2023 · 2403f7d · 2403f7d
1 parent b52e4a9
commit 2403f7d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 39 deletions.
diff --git a/dkpro-jwpl-api/pom.xml b/dkpro-jwpl-api/pom.xml
@@ -53,10 +53,6 @@
 			<groupId>de.fau.cs.osr.ptk</groupId>
 			<artifactId>ptk-common</artifactId>
 		</dependency>
-		<dependency>
-			<groupId>commons-logging</groupId>
-			<artifactId>commons-logging</artifactId>
-		</dependency>
 		<dependency>
 			<groupId>org.sweble.wikitext</groupId>
 			<artifactId>swc-parser-lazy</artifactId>

diff --git a/dkpro-jwpl-api/src/main/java/org/dkpro/jwpl/util/StringUtils.java b/dkpro-jwpl-api/src/main/java/org/dkpro/jwpl/util/StringUtils.java
@@ -17,13 +17,10 @@
  */
 package org.dkpro.jwpl.util;
 
-import java.io.File;
-import java.io.IOException;
 import java.lang.invoke.MethodHandles;
 import java.util.Collection;
 import java.util.Iterator;
 
-import org.apache.commons.io.FileUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -54,38 +51,6 @@ public static String join(Collection<?> c, String delimiter) {
 		return buffer.toString();
 	}
 
-	public static String getFileContent(String filename, String encoding) {
-
-		// File file = new File(filename);
-		//
-		// InputStream is;
-		// String textContents = "";
-		// try {
-		// is = new FileInputStream(file);
-		// // as the whole file is read at once -> buffering not necessary
-		// // InputStream is = new BufferedInputStream(new
-		// FileInputStream(file));
-		// byte[] contents = new byte[(int) file.length()];
-		// is.read(contents);
-		// textContents = new String(contents, encoding);
-		// } catch (FileNotFoundException e) {
-		// logger.error("File " + file.getAbsolutePath() + " not found.");
-		// e.printStackTrace();
-		// } catch (IOException e) {
-		// logger.error("IO exception while reading file " +
-		// file.getAbsolutePath());
-		// e.printStackTrace();
-		// }
-		File file = new File(filename);
-		try {
-			return FileUtils.readFileToString(file, encoding);
-		} catch (IOException e) {
-			logger.error("Exception while reading file " + file.getAbsolutePath(), e);
-			return "";
-		}
-
-	}
-
 	/**
 	 * Replaces all problematic characters from a String with their escaped
 	 * versions to make it SQL conform.

diff --git a/dkpro-jwpl-deps/dkpro-jwpl-swc-engine-shade/pom.xml b/dkpro-jwpl-deps/dkpro-jwpl-swc-engine-shade/pom.xml
@@ -36,11 +36,13 @@
             <groupId>commons-collections</groupId>
             <artifactId>commons-collections</artifactId>
             <version>3.2.2</version>
+            <scope>runtime</scope>
         </dependency>
         <dependency>
             <groupId>commons-io</groupId>
             <artifactId>commons-io</artifactId>
             <version>1.4</version>
+            <scope>runtime</scope>
         </dependency>
         <dependency>
             <groupId>de.fau.cs.osr.ptk</groupId>