Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#66 Add inflection group to word form #67

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

highsource
Copy link
Contributor

See #66.

This is a WIP PR, please do not merge yet.

@codecov-io
Copy link

codecov-io commented Aug 12, 2018

Codecov Report

Merging #67 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
+ Coverage     76.52%   76.57%   +0.05%     
+ Complexity     1352     1350       -2     
============================================
  Files           117      117              
  Lines          4749     4760      +11     
  Branches        798      799       +1     
============================================
+ Hits           3634     3645      +11     
  Misses          902      902              
  Partials        213      213
Impacted Files Coverage Δ Complexity Δ
...mstadt/ukp/jwktl/api/entry/WiktionaryWordForm.java 94.73% <100%> (+0.61%) 22 <3> (+1) ⬆️
...parser/de/components/nountable/EinzahlHandler.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...arser/de/components/nountable/SingularHandler.java 100% <100%> (ø) 4 <0> (ø) ⬇️
.../parser/de/components/nountable/PluralHandler.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...nountable/PatternBasedIndexedParameterHandler.java 94.11% <100%> (+4.11%) 4 <0> (+1) ⬆️
...mponents/nountable/DEWordFormNounTableHandler.java 92.85% <100%> (-1.59%) 7 <3> (-4)
...arser/de/components/nountable/MehrzahlHandler.java 100% <100%> (ø) 2 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e09454...523dca4. Read the comment docs.

@highsource
Copy link
Contributor Author

This is done and could (theoretically) be merged. But it depends on #65, so we have to review/fix/merge that one first - and probably this PR will be influenced by that as well.

@highsource highsource force-pushed the feature/66-Add-inflection-group-to-word-form branch from 2f1db24 to d51db8b Compare August 26, 2018 19:47
  - Added inflection group property to the word form interface
  - Setting inflection group in gender handlers
  - Added a test to check the default value of inflection group
  - Added a test case for multiple declension tables
  - Corrected index generation for the mutliple declention tables case
@highsource highsource force-pushed the feature/66-Add-inflection-group-to-word-form branch from ff9c9c5 to 523dca4 Compare December 19, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants