-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use portable-atomic when AtomicU64 is not available. #233
Conversation
Why do you need support for 0.8.x? |
As stated in the issue, I am trying to compile sccache. OpenDAL has this in their Cargo.toml: bb8 = { version = "0.8", optional = true } Due to semver rules, the most recent v0.8.x version compatible with all dependencies will be pulled in. |
Maybe get OpenDAL to update to bb8 0.9 instead? As a single volunteer maintainer I don't have much bandwidth for maintaining older versions. |
According to https://crates.io/crates/bb8/reverse_dependencies a lot more crates would need updating... This can be though of as a bug introduced in 0.8.4 that affects any system that does not have AtomicU64.
I'm willing to do the work, but what I can do depends on the level of permissions I have. |
I'm definitely not giving a complete stranger a bunch of permissions. If this (arguably a pretty niche issue) is so important to you, let's discuss funding? |
Dude, I'm just a random programmer that found a bug, reported it to the appropriate place and provided a fix for it with the suggested dependency. Donating my free time IS the kind of "funding" a person like me provides. If the funding you require is money then please wait for the unlikely case of someone whose job depends on this crate and who's company policy doesn't involve forking dependencies and fixing things internally... 😞 |
I appreciate that it sucks to be in your position. However, as someone who provides hundreds of hours per month of free labor to a zillion companies, doing backports (for this kind of niche architecture) is where I draw the line. (And after I pointed you in the right direction and reviewed your changes, I don't think I deserve being "Dude"d at.) |
I'm glad it got merged. It seems like 0.8.x won't be getting the fix which sucks a lot. Dude... you interpreted "dude" as something negative? |
edit Only fixes #232 if applied to a 0.8.x branch or if opendal moves to 0.9.x.
AtomicU64 was introduced in v0.8.4
The current version is 0.9.0, please update 0.8.x too.