Add build step to cache portal client artifact

.github/workflows/clojure.yml

@@ -20,26 +20,49 @@ jobs:
     - uses: actions/checkout@v3
     - uses: ./.github/setup
     - run: bb check
-  test-clj:
+  build:
     needs: [ setup ]
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
     - uses: ./.github/setup
+    - run: bb -m tasks.build/build
+    - uses: actions/upload-artifact@v4
+      with:
+        name: portal-client
+        path: resources/portal
+  test-clj:
+    needs: [ setup, build ]
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: ./.github/setup
+    - uses: actions/download-artifact@v4
+      with:
+        name: portal-client
+        path: resources/portal
     - run: bb -m tasks.test/clj
   test-cljs:
-    needs: [ setup ]
+    needs: [ setup, build ]
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
     - uses: ./.github/setup
+    - uses: actions/download-artifact@v4
+      with:
+        name: portal-client
+        path: resources/portal
     - run: bb -m tasks.test/cljs
   test-cljr:
-    needs: [ setup ]
+    needs: [ setup, build ]
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
     - uses: ./.github/setup
+    - uses: actions/download-artifact@v4
+      with:
+        name: portal-client
+        path: resources/portal
     - uses: actions/setup-dotnet@v4
       with:
         dotnet-version: '8.0.x'

dev/tasks/build.clj

@@ -12,7 +12,6 @@
     (npm :ci)))
 
 (defn main-js []
-  (install)
   (when (seq
          (fs/modified-since
           "resources/portal/main.js"
@@ -22,18 +21,19 @@
             "package-lock.json"
             "shadow-cljs.edn"]
            (fs/glob "src/portal/ui" "**.cljs"))))
+    (install)
     (shadow :release :client))
   (fs/copy "resources/icon.svg"
            "resources/portal/icon.svg"
            {:replace-existing true}))
 
 (defn ws-js []
-  (install)
   (let [out "resources/portal/ws.js"]
     (when (seq
            (fs/modified-since
             out
             ["package.json" "package-lock.json"]))
+      (install)
       (npx :browserify
            "--node"
            "--exclude" :bufferutil

dev/tasks/test.clj

@@ -24,7 +24,6 @@
     (t/node out)))
 
 (defn cljs-runtime [version]
-  (build)
   (cljs* {'org.clojure/clojurescript {:mvn/version version}} :portal.test-runtime-runner))
 
 (defn- get-cljs-deps []
@@ -47,6 +46,7 @@
   (setup* "1.10.844"))
 
 (defn cljs []
+  (build)
   (cljs-runtime "1.10.773")
   (cljs-runtime "1.10.844")
   (cljs-nbb)

test/portal/runtime/npm_test.cljc

@@ -1,8 +1,10 @@
 (ns portal.runtime.npm-test
   (:require [clojure.test :refer [deftest are]]
+            [portal.runtime.shell :refer [sh]]
             [portal.runtime.npm :refer [node-resolve]]))
 
 (deftest valid-modules
+  (sh "npm" "install" "react@^17.0.2")
   (are [module]
        (some? (node-resolve module))
     "react/jsx-runtime.js"