Fix #1722 -- Add more tests for fundraising webhook #1761
+390
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgmin
reviewed
Nov 23, 2024
| customer.return_value = self.stripe_data("customer") | ||
| payment_intent.return_value = self.stripe_data("payment_intent") | ||
| event = self.stripe_data("session_completed") | ||
| WebhookHandler(event).handle() |
There was a problem hiding this comment.
What's the reason behind not using self.post_event() like the other tests and calling the class directly?
| event = self.stripe_data("session_completed") | ||
| WebhookHandler(event).handle() | ||
| customer.assert_called_once() | ||
| payment_intent.assert_called_once() |
There was a problem hiding this comment.
Thinks that should also be tested:
- That the email is sent. There's an example above,
self.assertEqual(len(mail.outbox), 1) - That the response of the handler is the correct one, It should be a 204.
- What happens if the
DjangoHeroinstance doesn't exist (this should probably be a different test (or could be a new PR to add this to every event test since right now they don't check this case))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1722
Added test for
checkout_session_completed. The test fails when reverting the change in e995213.New files are added in
test_data. They were generated by calling callingstripe.Customer.list().data[0],stripe.PaymentIntent.list().data[0], etc.The
payment_succeededwebhook still needs a test, but I wanted a quick review to see if I've approached this correctly.@bmispelon @alexgmin