-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Trac query styling to be more compact and support mobile. #142
base: main
Are you sure you want to change the base?
Conversation
dab1f86
to
6453451
Compare
6453451
to
a545bca
Compare
a545bca
to
618c394
Compare
I've been looking for a way to add the description search field by default, would be great to at least have that added. |
Oooh… this looks fun @sarahboyce 🤩 I could particularly do with this for the Timeline view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a clear improvement over the status quo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, thanks for picking it up! 🚀
I think there's a few easy wins that we could already merge, but the CSS changes would require a more thorough review (we need to consider other pages that use the stylesheet, not just the ticket list).
Do you have the bandwidth to split things out into separate commits, or would you prefer if I did it?
@@ -259,6 +279,10 @@ div[role="main"]{ | |||
} | |||
} | |||
|
|||
#ctxtnav { | |||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the effect of this change? From my (limited) testing, the ctctnav
element is not present on the ticket list (I've seen it only on wiki pages)
@@ -76,6 +76,11 @@ <h1>Issues</h1> | |||
</div> | |||
</div> | |||
|
|||
|
|||
# if req.authname == 'anonymous' or req.authname == '': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use if not req.is_authenticated
I think
@@ -76,6 +76,11 @@ <h1>Issues</h1> | |||
</div> | |||
</div> | |||
|
|||
|
|||
# if req.authname == 'anonymous' or req.authname == '': | |||
<div id="guest"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the advantage of using this empty element rather than for example a class on the <body>
?
Changes:
No worries if it's not the right way to go with it, just thought I would have a play 👍 got me set up with the project
Also added mobile support