Make load_all() work with primary keys that are objects

[linkmic]

Required to support django-uuidfield as primary key.

[acdha]

That looks great – any chance you could contribute a test which would break currently?

[linkmic]

Hi,

I can give a test a crack, but it would make your tests depend on
django-uuidfield. Is that OK?

Also if you have a preference as to which test module you'd like the test
in, etc. then let me know.

Thanks,
/mike
On Dec 8, 2014 6:56 PM, "Chris Adams" [email protected] wrote:

That looks great – any chance you could contribute a test which would
break currently?

—
Reply to this email directly or view it on GitHub
https://github.com/toastdriven/django-haystack/pull/1115#issuecomment-66156436
.

[linkmic]

I have added a test now. It introduces a dependency on django-uuidfield unfortunately. Tell me if you can see a better way.

[linkmic]

The python 3.3 tests are failing currently because django-uuidfield uses the unicode() method without checking Python version. I have made an issue in that project and will monitor for a fix.
dcramer/django-uuidfield#51

[linkmic]

I can successfully run the tests locally using Python 3.4 and Django 1.6.0, provided I use the unreleased master branch of django-uuid which contains fixes for Python3.
dcramer/django-uuidfield@ec4f97f

I'd propose waiting for a new release of django-uuidfield before merging this pull request.

[acdha]

That seems reasonable – tempting as it is to have a simple test class for this, it should be less maintenance long-term to have a simple PyPI install

[linkmic]

I made a small improvement. Still waiting on django-uuidfield to release with Python 3 fixes.