Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added functionality where the toolbar inspects the loaded HTML content for a form that includes a file input but does not have the encoding type set to
multipart/form-data
, and warns the user if so.Subclassed Python's HTML parser and added a function called
check_invalid_file_form_configuration
inpanels/templates/panel.py
. The function checks all forms for a file input type and, if it exists, checks if the form has encoding type multipart/form-data. If it does not, the error message is shown in the Templates panel by passing it torecord_stats
. It also amends thenav_subtitle
property of the panel to notify the user that there is an issue with their template. Added three tests and checked that the test suite passes for all compatible versions of Django and Python through Tox.Fixes #1682
Checklist:
docs/changes.rst
.