Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving multiprocessing #156

Merged
merged 10 commits into from
Apr 22, 2022
Merged

Improving multiprocessing #156

merged 10 commits into from
Apr 22, 2022

Conversation

casabre
Copy link
Contributor

@casabre casabre commented Apr 21, 2022

The previous PR #148 introduced some errors and thus, the commits were reverted. In order to provide multiprocessing functionality, this new PR will be opened.

@casabre
Copy link
Contributor Author

casabre commented Apr 21, 2022

@dixudx I used your ThreadPool implementation and extended it by another ThreadPool in the base.py file. Now, it is really fast compared to the previous implementation. I guess, the ProcessPool was an overkill regarding spawning up.

@dixudx
Copy link
Owner

dixudx commented Apr 22, 2022

All look good to me, except tests for Python 2.7.

Keyword with will call pool.terminate() (i.e. __exit__) automatically , while for Python 2.7 pool.close() should be called instead.

@casabre I think we may need a Python decorator to better handle this compatibility.

@dixudx
Copy link
Owner

dixudx commented Apr 22, 2022

We have decided that January 1, 2020, was the day that we sunset Python 2.

I wonder whether we still need to support rtcclient on Python 2.7.

@casabre
Copy link
Contributor Author

casabre commented Apr 22, 2022

I wonder whether we still need to support rtcclient on Python 2.7.

I just wanted to ask the same. I don't know about the current real utilization of Python 2.7 but it's been a while since its end of life and thus, I would keep the effort low and would make the rtcclient future-proof 😊.

@casabre
Copy link
Contributor Author

casabre commented Apr 22, 2022

@dixudx PR is ready for v0.8.1 😃

@dixudx dixudx merged commit 82067c5 into dixudx:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants