-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use gnu sed in shell tests for cross-platform compatibility #441
Conversation
Darwin's use of BSD `sed` breaks here because BSD `sed` has a different argument signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
you should be able to bors r+
@Pacman99 I opted for a PR mainly to go through the exercise of learning about the CI/build process for PRs. |
bors r+ |
441: fix: use gnu sed in shell tests for cross-platform compatibility r=montchr a=montchr Darwin's use of BSD `sed` breaks here because BSD `sed` has a different argument signature. Spun off from #438 as suggested in #438 (comment) Co-authored-by: Chris Montgomery <[email protected]>
@Pacman99 anything in addition to the details in the bors getting started guide i should know about the process specific to divnix and digga? |
Build failed: |
Not that I can think of, i think you know everything about where checks are located. There is also bors try |
Strange that builds are hanging on this one… I cancelled the first run once it had been running for an hour. I stepped away and came back to find this build has been running for two hours… |
Yeah I'm not sure whats up with that 😕 And this PR doesn't change anything significant to change build times by that much |
tryBuild failed: |
bors try |
tryBuild succeeded: |
bors r+ |
Build succeeded: |
Darwin's use of BSD
sed
breaks here because BSDsed
has a differentargument signature.
Spun off from #438 as suggested in #438 (comment)