Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use gnu sed in shell tests for cross-platform compatibility #441

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

montchr
Copy link
Collaborator

@montchr montchr commented Mar 5, 2022

Darwin's use of BSD sed breaks here because BSD sed has a different
argument signature.

Spun off from #438 as suggested in #438 (comment)

Darwin's use of BSD `sed` breaks here because BSD `sed` has a different
argument signature.
Copy link
Member

@Pacman99 Pacman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
you should be able to bors r+

@montchr
Copy link
Collaborator Author

montchr commented Mar 5, 2022

@Pacman99 I opted for a PR mainly to go through the exercise of learning about the CI/build process for PRs. What steps do I take to run a CI build for this branch? You got there first! I haven't had enough coffee yet 🙃

@montchr
Copy link
Collaborator Author

montchr commented Mar 5, 2022

bors r+

bors bot added a commit that referenced this pull request Mar 5, 2022
441: fix: use gnu sed in shell tests for cross-platform compatibility r=montchr a=montchr

Darwin's use of BSD `sed` breaks here because BSD `sed` has a different
argument signature.

Spun off from #438 as suggested in #438 (comment)

Co-authored-by: Chris Montgomery <[email protected]>
@montchr
Copy link
Collaborator Author

montchr commented Mar 5, 2022

@Pacman99 anything in addition to the details in the bors getting started guide i should know about the process specific to divnix and digga?

@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

Build failed:

@Pacman99
Copy link
Member

Pacman99 commented Mar 5, 2022

Not that I can think of, i think you know everything about where checks are located. There is also bors delegate+ for giving PR authors ability to merge their own PRs once they get an up to date approval.

bors try

bors bot added a commit that referenced this pull request Mar 5, 2022
@montchr
Copy link
Collaborator Author

montchr commented Mar 5, 2022

Strange that builds are hanging on this one… I cancelled the first run once it had been running for an hour. I stepped away and came back to find this build has been running for two hours…

@Pacman99
Copy link
Member

Pacman99 commented Mar 5, 2022

Yeah I'm not sure whats up with that 😕
This one only took 8 min: https://github.com/divnix/digga/runs/5413509528?check_suite_focus=true

And this PR doesn't change anything significant to change build times by that much

@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

try

Build failed:

@montchr
Copy link
Collaborator Author

montchr commented Mar 5, 2022

bors try

bors bot added a commit that referenced this pull request Mar 5, 2022
@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

try

Build succeeded:

@montchr
Copy link
Collaborator Author

montchr commented Mar 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

Build succeeded:

@bors bors bot merged commit 8b88f51 into main Mar 5, 2022
@bors bors bot deleted the shell-gnused-from-pkgs branch March 5, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants