-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(arango): add arango api and bff to archi #135
Conversation
c38538c
to
4bd2e15
Compare
BFF/readme.md
Outdated
|
||
You also need a api.json file, that contains an array of `name` and `url` of all API you when to use. | ||
|
||
Notice that this minimal configuration you need is an API 'objects': | ||
|
||
Exemple of api.json: | ||
|
||
```json | ||
[ | ||
{"name":"server", "url": "http://localhost:8080"}, | ||
{"name":"objects", "url": "http://localhost:3001"} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part is a bit unclear, can the "name" key be anything we want ? because if not then isnt it better to simply add 2 environment variables ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name can be anything you want, like that you will be able to add N api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want one db for server and one for bay you can write config file like :
[
{"name":"server", "url": "http://localhost:8080"},
{"name":"bay", "url": "http://localhost:8081"},
{"name":"objects", "url": "http://localhost:3001"}
]
{"name":"server", "url": "http://ogree-core_arango_api:8080"}, | ||
{"name":"objects", "url": "http://ogree-core_api:3001"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the containers could have a different name depending on the COMPOSE_PROJECT_NAME environment variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you need to change this config to match your deployement...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The superadmin backend will need to do that then, so the deployment works directly without intervention of the user.
- use json instead of yaml for swagger - add routes post/get connections and devices - use api-doc container for bff - change PostDevices statusCode from Found to BadRequest - Remove useless code of arango-api
…flict with objects request
No description provided.