Spinner and Page Navigation issues #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
previously approved these changes
Sep 1, 2023
dashboard/src/modules/components/SidebarComponent/sideMenuOptions.js
Outdated
Show resolved
Hide resolved
webbnh
reviewed
Sep 1, 2023
dashboard/src/modules/components/SidebarComponent/sideMenuOptions.js
Outdated
Show resolved
Hide resolved
webbnh
approved these changes
Sep 5, 2023
Comment on lines
58
to
59
| export const menuOptionsNonLoggedIn = [ | ||
| { key: "dashboard", link: "/", name: "Dashboard" }, |
There was a problem hiding this comment.
In light of the change to HeaderComponent/index.jsx line 145, should the link field here should be changed to "/" + APP_ROUTES.HOME? (I think the answer is "no", but I don't know why. 😞)
dbutenhof
approved these changes
Sep 5, 2023
MVarshini
force-pushed
the
PBENCH-1263
branch
2 times, most recently
from
a471c63 to
95868cf
Compare
MVarshini
force-pushed
the
PBENCH-1263
branch
from
95868cf to
5e24a0a
Compare
Spinner and Page Navigation issues
MVarshini
force-pushed
the
PBENCH-1263
branch
from
5e24a0a to
1785a80
Compare
|
Since your rebase didn't clear the approvals, I'm tempted to merge this ... but I have a feeling that, with the CI ubi9 container problems we're seeing that will break the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1263
Spinner and Page Navigation issues
Header logo, it will re-direct tohomepageAll Runson side menu will showComing soontext