Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack SOS plugins support in pbench-collect-sysinfo #2135

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pradiptapks
Copy link

Added OpenStack SOS plugin support in pbench-sysinfo-dump and the plugin run based on the condition check of /etc/rhosp-release in the remote nodes.

dbutenhof
dbutenhof previously approved these changes Mar 15, 2021
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lists "dependency" modules (including podman, kvm) that aren't specifically "OpenStack", and that could lead to confusion later; however short of a complete new modular organization to detect specific plugins individually, I don't have any meaningful alternative to suggest and adding these seems useful.

@pradiptapks
Copy link
Author

@dbutenhof podman and kvm are still required as OSP container services managed by podman and kvm for OpenStack compute nodes.

#OpenStack plugin
OSP=/etc/rhosp-release
if [[ -f "$OSP" ]] ; then
_modules="${_modules} openstack_ansible openstack_aodh openstack_ceilometer openstack_cinder openstack_glance openstack_heat openstack_horizon openstack_instack openstack_ironic openstack_keystone openstack_manila openstack_neutron openstack_nova openstack_novajoin openstack_octavia openstack_placement openstack_swift os_net_config mssql cman ceph openvswitch ovn_central ovn_host pacemaker podman rabbitmq kernelrt ceph ceph-ansible kvm corosync"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradiptapks, is ceph supposed to be in the list twice?

@dbutenhof, should we be considering doing duplicate-removals on this list, or does it actually matter (i.e., will sosreport handle that adequately)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do plugins this way, because they are very tied to the version of the OS. Each one has to be check against the versions of sosreport that we execute against (RHEL 7.7, .8, .9, RHEL 8.*, RHEL 9, Fedora 32 & 33, CentOS 7 & 8, CentOS Streams?).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webbnh I removed ceph_ansible as ceph is sufficient to collect the log information.

@portante OpenStack parsers in sosreport are common to RHEL7.x, 8.x, CentOS, Fedora. As podman has introduced in RHEL8.x, I wonder whether it does backwards support below version 3. May I know which version of so start support podman, so that I can change the condition.

Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, sosreport modules are tough to manage.

We have to be careful that they don't balloon the size of the data collected (no logs, etc.).

We really need a mechanism for the user to specify the list of modules they want so that they can own what is collected.

#OpenStack plugin
OSP=/etc/rhosp-release
if [[ -f "$OSP" ]] ; then
_modules="${_modules} openstack_ansible openstack_aodh openstack_ceilometer openstack_cinder openstack_glance openstack_heat openstack_horizon openstack_instack openstack_ironic openstack_keystone openstack_manila openstack_neutron openstack_nova openstack_novajoin openstack_octavia openstack_placement openstack_swift os_net_config mssql cman ceph openvswitch ovn_central ovn_host pacemaker podman rabbitmq kernelrt ceph ceph-ansible kvm corosync"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do plugins this way, because they are very tied to the version of the OS. Each one has to be check against the versions of sosreport that we execute against (RHEL 7.7, .8, .9, RHEL 8.*, RHEL 9, Fedora 32 & 33, CentOS 7 & 8, CentOS Streams?).

@portante portante self-assigned this Mar 16, 2021
@portante portante added the Agent label Mar 16, 2021
@portante portante added this to the v0.71 milestone Mar 16, 2021
@pradiptapks pradiptapks force-pushed the OpenStack-SOS-Plugins branch from cb73644 to 08582e6 Compare March 18, 2021 07:19
# sos-plugins for OpenStack cloud
OSP=/etc/rhosp-release
if [[ -f "$OSP" ]] ; then
_modules="${_modules} openstack_ansible openstack_aodh openstack_ceilometer openstack_cinder openstack_glance openstack_heat openstack_horizon openstack_instack openstack_ironic openstack_keystone openstack_manila openstack_neutron openstack_nova openstack_novajoin openstack_octavia openstack_placement openstack_swift os_net_config mssql cman ceph openvswitch ovn_central ovn_host pacemaker podman rabbitmq kernelrt ceph kvm corosync"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether it actually matters, but I still see ceph in this list twice -- once after cman and once after kernelrt.

@portante portante modified the milestones: v0.71, v0.72 Apr 13, 2021
@portante portante marked this pull request as draft April 28, 2021 13:00
@portante portante modified the milestones: v0.72, v0.73 Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants