-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code commit #2
Conversation
50f77c1
to
2e3f3d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable initial commit.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
=======================================
Coverage ? 98.52%
=======================================
Files ? 2
Lines ? 543
Branches ? 0
=======================================
Hits ? 535
Misses ? 8
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sent feedback to the Codecov folks and also replied in codecov/feedback#8 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like basically the same code I reviewed before. I don't think it's useful to Pbench in the current form (especially, insufficient information to define a dataset before pulling a large amount of data); but if it makes you feel better to submit a baseline for reference, go for it.
This is the inaugural commit of the
file-relay
code, infrastructure, and GitHub setup. (However, I had to submit the GitHub Actions configuration itself separately, as it doesn't use the contents of a PR to test that PR, which means that the config has to be submitted ahead of the rest.)After much sweat and gnashing of teeth, I believe I have GitHub Actions running a CI which accepts this change (but, it depends on stuff in this change, so it currently rejects
main
...).While this submission is "functionally complete" (i.e., the interfaces seem to work, as do the unit tests), this is not the final form. There are several items which we will probably want before Pbench can make full use of this:
But, what is here is a reasonable start.