Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code commit #2

Merged
merged 3 commits into from
May 9, 2023
Merged

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented May 4, 2023

This is the inaugural commit of the file-relay code, infrastructure, and GitHub setup. (However, I had to submit the GitHub Actions configuration itself separately, as it doesn't use the contents of a PR to test that PR, which means that the config has to be submitted ahead of the rest.)

After much sweat and gnashing of teeth, I believe I have GitHub Actions running a CI which accepts this change (but, it depends on stuff in this change, so it currently rejects main...).

While this submission is "functionally complete" (i.e., the interfaces seem to work, as do the unit tests), this is not the final form. There are several items which we will probably want before Pbench can make full use of this:

  • The hash algorithm for resource names might need to be changed or made configurable
  • The underlying web server may be changed from the reference one to Gunicorn or other
  • The web server should be made able to accept SSL connections
  • The utility needs to be packaged, either as a Python package or a container (or both)
  • Figure out what the server status response should contain -- currently, it provides a list of the available files, which undermines the "ya gotta know it's there" story, but it's handy for testing and debugging.

But, what is here is a reasonable start.

@webbnh webbnh self-assigned this May 4, 2023
@webbnh webbnh force-pushed the initial-code branch 8 times, most recently from 50f77c1 to 2e3f3d0 Compare May 4, 2023 21:33
@webbnh webbnh marked this pull request as ready for review May 4, 2023 22:04
@webbnh webbnh added documentation Improvements or additions to documentation enhancement New feature or request infrastructure CI, build, test harness, configuration, etc. labels May 4, 2023
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable initial commit.

pyproject.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@7c316e3). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   98.52%           
=======================================
  Files           ?        2           
  Lines           ?      543           
  Branches        ?        0           
=======================================
  Hits            ?      535           
  Misses          ?        8           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@webbnh
Copy link
Member Author

webbnh commented May 5, 2023

❗ No coverage uploaded for pull request base (main@7c316e3). Click here to learn what that means.
Patch has no changes to coverable lines.

Sent feedback to the Codecov folks and also replied in codecov/feedback#8 .

Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like basically the same code I reviewed before. I don't think it's useful to Pbench in the current form (especially, insufficient information to define a dataset before pulling a large amount of data); but if it makes you feel better to submit a baseline for reference, go for it.

@webbnh webbnh merged commit 18cccb4 into distributed-system-analysis:main May 9, 2023
@webbnh webbnh deleted the initial-code branch May 9, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request infrastructure CI, build, test harness, configuration, etc.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants