Rewriting the hash_to_range function #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bution. Now it uses seeded random based on ChaCha12Rng instead of DefaultHash as before. Also, it fixes distribution in range by executing selection several times to achieve uniform distribution when range != 2^k
NikitaMasych
force-pushed
the
feature/new-range-random
branch
from
f9545ef to
bb704a8
Compare
NikitaMasych
force-pushed
the
feature/new-range-random
branch
from
bb704a8 to
53f9c5b
Compare
|
Hey guys, I will be merging this PR to get a clear picture on the final epic, however feel free to write comments and we'll resolve them |
NikitaMasych
added a commit
that referenced
this pull request
Aug 29, 2024
* feat: moved leader computation to party, added ballot number to seed * feat: add configuration of timebounds for events, async * feat: use hash-based leader election instead of rand * fix: resolved events sending * feat: added status checks to update_state * feat: add timeout handling for latency between parties * feat: add opportunity to configure prior to launch timeout * feat: changed logic for leader election * feat: refactor leader election components * Rewriting the hash_to_range function (#8) * rewriting the hash_to_range function to achieve better uniform distribution. Now it uses seeded random based on ChaCha12Rng instead of DefaultHash as before. Also, it fixes distribution in range by executing selection several times to achieve uniform distribution when range != 2^k * Adding comments * fix: resolved linter issues/failing tests --------- Co-authored-by: Nikita Masych <[email protected]> --------- Co-authored-by: Oleg Fomenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting the hash_to_range function to achieve better uniform distribution.
Now it uses seeded random based on ChaCha12Rng instead of DefaultHash as before. Also, it fixes distribution in range by executing selection several times to achieve uniform distribution when range != 2^k