Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: primary implementation of the protocol #6

Merged
merged 21 commits into from
Aug 15, 2024

Conversation

olegfomenko
Copy link
Contributor

@olegfomenko olegfomenko commented Aug 2, 2024

What?

This PR brings in primary implementation part for the consensus and library overall.

@olegfomenko olegfomenko changed the title Epic/base ballot logic Epic: Adding basic ballot logic Aug 2, 2024
@NikitaMasych NikitaMasych linked an issue Aug 5, 2024 that may be closed by this pull request
src/message.rs Outdated Show resolved Hide resolved
src/party.rs Outdated Show resolved Hide resolved
src/party.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general -- left a few minor comments.

If the message contents aren't going to be changing then I would much prefer to see a binary serialization instead of serde_json which is notoriously slow and results in much larger payloads. Can recommend protobuf, speedy and rkyv, or even manual serialization if the messages are fixed.

Just for general info I do have some serialization benchmarking here (code here) for some stacks-core stuff, if that helps with some inspiration.

@NikitaMasych NikitaMasych self-assigned this Aug 12, 2024
@NikitaMasych NikitaMasych added the enhancement New feature or request label Aug 12, 2024
@NikitaMasych NikitaMasych changed the title Epic: Adding basic ballot logic feat: primary implementation of the protocol Aug 15, 2024
@NikitaMasych NikitaMasych merged commit 5acf84a into main Aug 15, 2024
11 checks passed
@NikitaMasych NikitaMasych deleted the epic/base-ballot-logic branch August 15, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implementing ballot protocol
3 participants