-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: primary implementation of the protocol #6
Conversation
… config-based seed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general -- left a few minor comments.
If the message contents aren't going to be changing then I would much prefer to see a binary serialization instead of serde_json
which is notoriously slow and results in much larger payloads. Can recommend protobuf
, speedy
and rkyv
, or even manual serialization if the messages are fixed.
Just for general info I do have some serialization benchmarking here (code here) for some stacks-core stuff, if that helps with some inspiration.
…it error handling
What?
This PR brings in primary implementation part for the consensus and library overall.