Changed ZKP for working with chunked veiled balance #7
Conversation
…n-builders-veiled-balance-operations
…rs-veiled-balance-operations
… add common method for getting sigma and range proofs with new balance as in the docs
Refactoring veiled coin feature
src/api/veiledCoin.ts
Outdated
| ): Promise<InputGenerateTransactionPayloadData> { | ||
| const veiledNormalization = await VeiledNormalization.create({ | ||
| decryptionKey: args.decryptionKey, | ||
| unnormilizedEncryptedBalance: args.unnormilizedEncryptedBalance, |
| RistrettoPoint.ZERO, | ||
| ) | ||
| .multiply(alpha2LE); | ||
| const pBlaOld = opts.unnormilizedEncryptedBalance |
| TwistedElGamal.encryptWithPK(chunk, this.senderDecryptionKey.publicKey(), this.randomness[i]), | ||
| ); | ||
|
|
||
| const i = 4; |
There was a problem hiding this comment.
Comment explaining what i and j represent?
tests/e2e/api/veiledCoin.test.ts
Outdated
| * Address of the module for minting mocked fungible tokens on the testnet | ||
| */ | ||
| const MODULE_ADDRESS = "0xcbd21318a3fe6eb6c01f3c371d9aca238a6cd7201d3fc75627767b11b87dcbf5"; | ||
| // TODO: decimals? |
There was a problem hiding this comment.
What is this TODO for?
There was a problem hiding this comment.
just renamed it. I was gonna add tests with token with 10^18 precision
| export const addNewContentLineToFile = (filename: string, data: string) => { | ||
| const filePath = path.resolve(rootDir, filename); | ||
|
|
||
| const content = `\n#TESTNET_DK=${data}\n`; |
There was a problem hiding this comment.
What does TESTNET_DK mean here?
There was a problem hiding this comment.
I assume it means "testnet decryption key" but why is it hardcoded in a function called "addNewContentLineToFile"?
There was a problem hiding this comment.
I used it to test key rotation, and in order to not to forget or lose new dk, i write it to .env.development file, just for testing purposes
There was a problem hiding this comment.
Can you add a comment describing this?
|
Looks good - some minor comments and questions |
… typo for normalization
…-balance # Conflicts: # src/api/veiledCoin.ts # tests/unit/veiled/api/normalize.test.ts
BSGS & Bernstein Lange amount decryption algorithms
Fix range proof approach & normalization
No description provided.