Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.10 #1580

Merged
merged 15 commits into from
Oct 26, 2024
Merged

Update sbt to 1.10 #1580

merged 15 commits into from
Oct 26, 2024

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Sep 6, 2024

Closes #1538.

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@kubukoz
Copy link
Member Author

kubukoz commented Sep 6, 2024

I've bisected the header problem down to https://github.com/sbt/sbt/releases/v1.9.7, I suspect it's this change: sbt/sbt#7404

the current state is that headerLicense is unset in most projects.

@Baccata
Copy link
Contributor

Baccata commented Sep 10, 2024

Well let's either set it or disable the header plugin altogether on irrelevant projects

@kubukoz kubukoz marked this pull request as ready for review October 25, 2024 19:06
Comment on lines +20 to +21
> ++3.3.0
> root/compile
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what happened here.

@kubukoz kubukoz merged commit 31e6188 into series/0.18 Oct 26, 2024
11 checks passed
@kubukoz kubukoz deleted the update-sbt branch October 26, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: update sbt in the project and scripted tests
2 participants