Dynamic: support open enums #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Oct 5, 2023
| @@ -256,9 +256,33 @@ private[dynamic] object Compiler { | |||
| ) | |||
| } | |||
|
|
|||
| val theEnum = stringEnumeration(values, values) | |||
| if (shape.traits.contains(IdRef("alloy#openEnum"))) { | |||
| // the runtime representation of normal enums is Int, but for open enums it's String to support arbitrary unknown values. | |||
There was a problem hiding this comment.
question: should we go for a String representation for all the cases?
There was a problem hiding this comment.
I suppose that'd make sense.
There was a problem hiding this comment.
Although, int is fine for the closed-enum case
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Show resolved
Hide resolved
Baccata
approved these changes
Oct 7, 2023
Baccata
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1243