Facilitate the loading of AWS specifications #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Baccata
commented
Sep 27, 2023
•
Baccata
commented
- Adds logic to code-generate a list of artifacts containing AWS specifications in a Scala object
- Add build tasks (for SBT and Mill) to lower the barrier of entry for referencing those artifacts in their build. Since the artifacts are listed as Scala values, the users get auto-completion to help set-up the code generation of AWS services.
- Added corresponding tests for both SBT and Mill, avoiding the compilation of the generated code to save on CI time.
Baccata
changed the title
kubukoz
approved these changes
Sep 27, 2023
daddykotex
reviewed
Sep 27, 2023
project/AwsBoilerplate.scala
Outdated
|
|
||
| private case class Module(service: String, name: String) | ||
| private type GenModule = String :*: String :*: LNil | ||
| private object Module { |
There was a problem hiding this comment.
do you still need that sjsonnew stuff? since you're parsing with jsoniter?
There was a problem hiding this comment.
good point, I can remove 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.