Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New API]: College_Lectures_API #82

Merged
merged 2 commits into from
May 14, 2024
Merged

[New API]: College_Lectures_API #82

merged 2 commits into from
May 14, 2024

Conversation

Asymtode712
Copy link
Contributor

🎯 Title and Issue Number

Closes #79

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @Asymtode712, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@Asymtode712 Asymtode712 changed the title Added College_Lectures_API [New API]: College_Lectures_API May 12, 2024
dishamodi0910
dishamodi0910 requested changes May 13, 2024
View reviewed changes
Copy link
Owner

@dishamodi0910 dishamodi0910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Asymtode712, Instead of using the sample data from your side, try to use MONGODB database inorder to make one completely aware of how they can interact with database instead of static data for achieving the same functionality.

This would be more beneficial to let this PR go under LEVEL 3 for GSSOC'24!

@dishamodi0910 dishamodi0910 added under-review Review PR! changes-requested Changes are needed. labels May 13, 2024
@Asymtode712
Copy link
Contributor Author

Sure! Working on your suggestion!!!

@Asymtode712
Copy link
Contributor Author

Hey @dishamodi0910, I have connected MongoDB to avoid the use of static data. Please check my PR and merge it if it is good to go

@dishamodi0910
Copy link
Owner

Yup, looks great now @Asymtode712✨!

@dishamodi0910 dishamodi0910 merged commit 77146c3 into dishamodi0910:master May 14, 2024
@dishamodi0910
Copy link
Owner

@Asymtode712 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣️🔥
Happy Coding! ✨
Will See you soon❣️

@dishamodi0910 dishamodi0910 added awesome Merged🎊 Merged PR gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS and removed under-review Review PR! changes-requested Changes are needed. labels May 14, 2024
@Asymtode712
Copy link
Contributor Author

@dishamodi0910 please assign me this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dishamodi0910 dishamodi0910 dishamodi0910 approved these changes

Assignees
No one assigned
Labels
awesome gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS Merged🎊 Merged PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New API] : College Lectures API
2 participants
@Asymtode712 @dishamodi0910