Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IIT ISM Subjects API Issue [#69] #76

Merged
merged 2 commits into from
May 14, 2024
Merged

IIT ISM Subjects API Issue [#69] #76

merged 2 commits into from
May 14, 2024

Conversation

pspriyanshu601
Copy link
Contributor

@pspriyanshu601 pspriyanshu601 commented May 12, 2024 •
edited
Loading

🎯 [New API] : IIT ISM Subjects API issue 69

Closes #<69

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.
    Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @pspriyanshu601, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@pspriyanshu601
Copy link
Contributor Author

pspriyanshu601 commented May 13, 2024 •
edited
Loading

@dishamodi0910 Please review my PR , I don't have any merge conflicts and I have followed all of your contribution guidelines . Fast response will be appreciated 😊

dishamodi0910
dishamodi0910 requested changes May 13, 2024
View reviewed changes
Copy link
Owner

@dishamodi0910 dishamodi0910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the example responses from README.md file.
Mention about where this API can be used in README.md file.

@dishamodi0910 dishamodi0910 added under-review Review PR! changes-requested Changes are needed. labels May 13, 2024
@pspriyanshu601
Copy link
Contributor Author

@dishamodi0910 I have removed the example responses and mentioned about where this api can be used in the README.md file as you asked for .
Please review this and merge , a quick response will be appreciated .

@pspriyanshu601 pspriyanshu601 mentioned this pull request May 14, 2024
Closed
@dishamodi0910
Copy link
Owner

Looks good @pspriyanshu601😄!

@dishamodi0910 dishamodi0910 merged commit c1a3788 into dishamodi0910:master May 14, 2024
@dishamodi0910
Copy link
Owner

@pspriyanshu601 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣️🔥
Happy Coding! ✨
Will See you soon❣️

@dishamodi0910 dishamodi0910 added Merged🎊 Merged PR gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS awesome and removed under-review Review PR! changes-requested Changes are needed. labels May 14, 2024
@pspriyanshu601 pspriyanshu601 deleted the iitism-subjects-feature branch May 14, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dishamodi0910 dishamodi0910 dishamodi0910 approved these changes

Assignees
No one assigned
Labels
awesome gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS Merged🎊 Merged PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New API] : IIT ISM Subjects API
2 participants
@pspriyanshu601 @dishamodi0910