Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New API - Library API #72

Merged
merged 2 commits into from
May 14, 2024

Conversation

mdrehan369
Copy link
Contributor

🎯 Title and Issue Number

Closes #56

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @mdrehan369, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@dishamodi0910
Copy link
Owner

@mdrehan369, Great job! 🚀

It would be great if you could add the feature of penalty as well that is set the expiry time once someone borrows the book. Make sure that they return the book within the expiry time, or else they would be charged some penalty, This could be great addition to boost this PR to level 3!

@dishamodi0910 dishamodi0910 added the under-review Review PR! label May 13, 2024
@dishamodi0910 dishamodi0910 self-requested a review May 13, 2024 12:03
Copy link
Owner

@dishamodi0910 dishamodi0910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required as mentioned!

@dishamodi0910 dishamodi0910 added the changes-requested Changes are needed. label May 13, 2024
@mdrehan369
Copy link
Contributor Author

Changes required as mentioned!

Okay mam I am on it!

@mdrehan369
Copy link
Contributor Author

I added the requested functionality #72

@dishamodi0910
Copy link
Owner

Looks good now @mdrehan369!🎇

@dishamodi0910 dishamodi0910 merged commit ce16bf5 into dishamodi0910:master May 14, 2024
@dishamodi0910
Copy link
Owner

@mdrehan369 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣️🔥
Happy Coding! ✨
Will See you soon❣️

@dishamodi0910 dishamodi0910 added awesome Merged🎊 Merged PR gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS and removed under-review Review PR! changes-requested Changes are needed. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome gssoc New label for GSSOC-24 level3 NEW API/3 EXISTING API ENHANCEMENTS/5 BUGS Merged🎊 Merged PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New API] : Library API
2 participants