Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Weather API #312

Closed

Conversation

Saipradyumnagoud
Copy link

🎯 Title and Issue Number

Added Weather API

Closes #311

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤️

Don't forget to show some love by ⭐ the repository!

@dishamodi0910
Copy link
Owner

Hey @Saipradyumnagoud, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@Saipradyumnagoud
Copy link
Author

@dishamodi0910 Please Review it soon

@Saipradyumnagoud
Copy link
Author

@dishamodi0910 It has been 2 weeks since i raised the issue and the pull request there is no review yet

@Saipradyumnagoud
Copy link
Author

@dishamodi0910 please review the pull reqst let me know the changes

@dishamodi0910
Copy link
Owner

@Saipradyumnagoud, Please make following changes and raise the PR again,

  1. Remove the API Key. We never expose credentials, you can mention some dummy string value there like "your api key".
  2. Mention in README.md file about how to generate the API key. Provide the source link.
  3. As you are using some already existing API to fetch the data, so change the directory of your API to existing api collection folder.

Once all the changes are done, please create the NEW PR.

@dishamodi0910
Copy link
Owner

@Saipradyumnagoud ,I wanted to reach out and let you know that we have decided to close your pull request.🙇

In case of any issues, you can contact us on Discord.
Thank you! ❣️
Happy Coding! ✨
Will See you soon❣️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New API] : Add Weather Api
2 participants